Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI:DOCS] Updated Troubleshooting.md Closes #5431 #11249

Merged
merged 1 commit into from
Aug 19, 2021
Merged

[CI:DOCS] Updated Troubleshooting.md Closes #5431 #11249

merged 1 commit into from
Aug 19, 2021

Conversation

afro-coder
Copy link
Contributor

Hi,

I didn't know what to do to remove the previous commits that had the whitespace issue so I deleted the branch itself.

This is a fresh branch I've checked with 3 different methods, including the commands from the vim wiki for trailing whitespaces but I couldn't find any.

I'm hoping this doesn't fail.
Closes #5431

@mheon
Copy link
Member

mheon commented Aug 17, 2021

Gitvalidation is complaining about a signoff - can you add one with git commit --amend -s and force-push?

@rhatdan
Copy link
Member

rhatdan commented Aug 17, 2021

You have to sign your commits, could you please sign and fix your commit message to something useful,

git commit -a --amend -s
git push --force

@rhatdan
Copy link
Member

rhatdan commented Aug 17, 2021

@TomSweeneyRedHat PTAL

@afro-coder afro-coder force-pushed the troubleshooting-update branch 2 times, most recently from 4ef1cb3 to 2f7cd62 Compare August 17, 2021 19:18
@afro-coder
Copy link
Contributor Author

Thank you for being patient with me @mheon and @rhatdan not sure why git wasn't picking up the GPG key but forcing it to do so did verify it.

@rhatdan
Copy link
Member

rhatdan commented Aug 17, 2021

LGTM, although you should put the closes #5431 in the body of the commit, not in the heading.

@afro-coder
Copy link
Contributor Author

Oh, I didn't know about the Commit heading and body part can I do a git commit -a --amend -s and git push --force again, since it'll run all the tests again, is that alright?

@rhatdan
Copy link
Member

rhatdan commented Aug 17, 2021

Yes.

@afro-coder
Documented ways to fix firewall rules that are lost when firewalld re…
970529b 
…loads

Closes containers#5431

Signed-off-by: afro-coder <leon9923@gmail.com>
@TomSweeneyRedHat
Copy link
Member

LGTM
Thanks @afro-coder!

@TomSweeneyRedHat
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2021
@rhatdan
Copy link
Member

rhatdan commented Aug 17, 2021

Thanks @afro-coder

@afro-coder
Copy link
Contributor Author

Thank you for being so patient with me

@rhatdan
Copy link
Member

rhatdan commented Aug 19, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afro-coder, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2021
@openshift-merge-robot openshift-merge-robot merged commit 2cb304d into containers:main Aug 19, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@TomSweeneyRedHat TomSweeneyRedHat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CNI: Make firewalld rules --permanent
5 participants
@afro-coder @mheon @rhatdan @TomSweeneyRedHat @openshift-merge-robot